fix: #1002 #1010
Merged
fix: #1002 #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 27.83% // Head: 27.81% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1010 +/- ##
=============================================
- Coverage 27.83% 27.81% -0.02%
+ Complexity 687 686 -1
=============================================
Files 241 241
Lines 5666 5666
Branches 513 513
=============================================
- Hits 1577 1576 -1
- Misses 3943 3944 +1
Partials 146 146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
magestacks
reviewed
Nov 23, 2022
hippo4j-example/hippo4j-config-nacos-spring-boot-1x-starter-example/pom.xml
Show resolved
Hide resolved
magestacks
reviewed
Nov 23, 2022
...er/src/main/java/cn/hippo4j/config/springboot/starter/config/ConfigHandlerConfiguration.java
Show resolved
Hide resolved
magestacks
reviewed
Nov 23, 2022
...er/src/main/java/cn/hippo4j/config/springboot/starter/config/ConfigHandlerConfiguration.java
Show resolved
Hide resolved
magestacks
reviewed
Nov 23, 2022
...src/main/java/cn/hippo4j/config/springboot/starter/refresher/NacosCloudRefresherHandler.java
Show resolved
Hide resolved
magestacks
reviewed
Nov 23, 2022
...n/java/cn/hippo4j/springboot/starter/monitor/local/log/LocalLogMonitorAutoConfiguration.java
Show resolved
Hide resolved
# Conflicts: # hippo4j-spring-boot/hippo4j-config-spring-boot-starter/src/main/java/cn/hippo4j/config/springboot/starter/refresher/NacosCloudRefresherHandler.java # hippo4j-spring-boot/hippo4j-config-spring-boot-starter/src/main/java/cn/hippo4j/config/springboot/starter/refresher/NacosRefresherHandler.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1002
Changes proposed in this pull request: